Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add write_datasources an fix pkgdown #56

Merged
merged 4 commits into from
Dec 17, 2024
Merged

feat: add write_datasources an fix pkgdown #56

merged 4 commits into from
Dec 17, 2024

Conversation

Cervangirard
Copy link
Contributor

@Cervangirard Cervangirard commented Dec 11, 2024 •
edited
Loading

Main feature is write_datasources() function that:

  • Persists connector configurations to file
  • Supports multiple formats (yml/yaml/json/rds)
  • Has format-specific handling (JSON class stripping)
  • Includes robust input validation

Some fixs:

  • remove get_file_ext fot tools::file_ext
  • update documentation for pkgdown
  • add json as a supported write file

To test :

Key files to review:

  • R/conts_datasources.R -> write_datasources
  • test-cnts_datasources.R

Remember to:

  • Test all supported formats
  • Verify error handling

@Cervangirard Cervangirard marked this pull request as ready for review December 12, 2024 07:51
Cervangirard and others added 2 commits December 17, 2024 09:10
@Cervangirard
fix: update news and description
268c14e
@Troejelsgaard @NNktqn
Some small edits (#58)
7a05fa4 
Co-authored-by: KTQN (Kristian Trøjelsgaard Nielsen) <[email protected]>
@github-actions GitHub Actions
Copy link

Code coverage

Name Coverage (%)
connector 76.63
R/cnt_generics.R 35.71
R/connect_utils.R 100.00
R/connect.R 95.43
R/connector.R 14.29
R/connectors.R 67.86
R/conts_datasources.R 98.04
R/dbi_backend_tools.R 66.67
R/dbi_methods.R 100.00
R/dbi.R 100.00
R/fs_backend_tools.R 66.67
R/fs_methods.R 100.00
R/fs_read.R 42.86
R/fs_write.R 76.92
R/fs.R 100.00
R/generic_backend.R 96.55
R/utils_files.R 100.00
R/utils-docs.R 0.00
R/utils-roxygen.R 0.00

@github-actions GitHub Actions
Copy link

Github pages

Review the pkgdown webpage for the PR here

@Cervangirard Cervangirard merged commit d2f0a44 into main Dec 17, 2024
13 of 14 checks passed
@Cervangirard Cervangirard deleted the feat/add_write_config_yaml branch December 17, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Troejelsgaard Troejelsgaard Troejelsgaard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cervangirard @Troejelsgaard